Slashcode

02/06/03/1816213 story

Images Within Comments

posted by Krow on 02:16 PM June 3rd, 2002      

I've asked this before, but I've never gotten a solid answer.

Why is it that, even after I add "IMG" to the approvedtags variable, users still cannot include images in their comments? I've restarted slash and apache, but the results are always the same.

Now, some of you might be wondering why I would want to do this. I've heard all of the concerns about security, but every forum software package I've seen includes this feature. Aside from wanting to let my users pretty up the page for me, I'd really like to start doing Photoshop contests and whatnot, without having to fall back upon a simple text link to their images.

If anyone could provide a solution or at least point me in the right direction, I would appreciate it.
--
Nastard

• Looked in DB? (Score:0)

  by Anonymous Coward

  Have you looked in the DB to see what the comments look like? I would not be surprised if the " got replaced with an &, and that is the cause of your problems.
• Try IMG .* (Score:2)

  by davidt (71)

  Instead of just "IMG"
  
  try "IMG .*"
  
  I think the src throws it off.
  • Re:Try IMG .* (Score:2)

    by davidt (71)

    Some code modification still might be necessary. I just tried it on my test slash site and the code will close the <IMG SRC="http://...">:
    
    </IMG SRC="http://...">
    
    which messes up the page.
    • Re:Try IMG .* (Score:1)

      by ChristTrekker (1204)

      Code probably doesn't parse for empty tags. Try posting with XHTML-syntax <IMG SRC=...></IMG> instead.

      --
      ⇒ Constitutionally Correct [cpne.org] ⇐
      • Re:Try IMG .* (Score:2)

        by davidt (71)

        Yes, that will fix it. Some code modifications (probably similar to the <A HREF> tag) will still be necessary as most people won't include the closing IMG tag.
      • Re:Try IMG .* (Score:1)

        by Nastard (1588)

        What would I put in the allowedtags?
      • Re:Try IMG .* (Score:1)

        by J'raxis (2959)

        Um, <BR> tags are allowed. How is that specified in the code?

        --
        

        Liberty in your lifetime [jraxis.com]
• Variables-approved_url_schemes (Score:2)

  by ericdano (1000)

  I think you need to look into this variable. Perhaps adding IMG SRC would make it work?

  --
  
  --
  It's either on the beat or off the beat, it's that easy.